lburgazzoli commented on code in PR #5488:
URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595269905
##########
pkg/trait/jvm.go:
##########
@@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool,
*TraitCondition, error) {
if e.CamelCatalog == nil {
return false,
NewIntegrationConditionPlatformDisabledCatalogMissing(), nil
}
+
+ if t.Jar == "" && e.IntegrationKit != nil {
+ executableArtifact := e.IntegrationKit.GetExecutableArtifact()
+ if executableArtifact == nil {
+ return false, nil, fmt.Errorf("could not locate any
executable among Integration Kit %s artifacts", e.IntegrationKit.Name)
+ }
+ t.Jar = executableArtifact.Target
Review Comment:
maybe a stupid question since I'm unable to figure out how all the bits are
wiring together, but is this backward compatible ? i.e. what would happen for
already existing kits & running integrations ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
