christophd commented on code in PR #5346:
URL: https://github.com/apache/camel-k/pull/5346#discussion_r1559134636
##########
e2e/common/traits/health_test.go:
##########
@@ -362,6 +362,8 @@ func TestHealthTrait(t *testing.T) {
g.Eventually(IntegrationPodPhase(t, ctx, ns, name),
TestTimeoutLong).Should(Equal(corev1.PodRunning))
g.Eventually(IntegrationPhase(t, ctx, ns, name),
TestTimeoutShort).Should(Equal(v1.IntegrationPhaseRunning))
+ // Wait for the integration condition to become
ready=false and then check that it remains not ready for some time - fixes some
test flakiness
Review Comment:
You can find my analysis of the root cause in #5345. It is the Deployment
ready state that causes the intermediate Integration condition status
`ready=true`. This is before the health trait is able to set the condition
status to `false`.
My intention in this PR is to fix the flaky E2E test. In case we are not
happy with the intermediate condition status `ready=true` I'd suggest to open a
new issue and discuss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
