christophd commented on code in PR #5346:
URL: https://github.com/apache/camel-k/pull/5346#discussion_r1559128613
##########
e2e/common/traits/health_test.go:
##########
@@ -362,6 +362,8 @@ func TestHealthTrait(t *testing.T) {
g.Eventually(IntegrationPodPhase(t, ctx, ns, name),
TestTimeoutLong).Should(Equal(corev1.PodRunning))
g.Eventually(IntegrationPhase(t, ctx, ns, name),
TestTimeoutShort).Should(Equal(v1.IntegrationPhaseRunning))
+ // Wait for the integration condition to become
ready=false and then check that it remains not ready for some time - fixes some
test flakiness
+ g.Eventually(IntegrationConditionStatus(t, ctx, ns,
name, v1.IntegrationConditionReady),
TestTimeoutShort).Should(Equal(Equal(corev1.ConditionFalse)))
Review Comment:
yeah two equal does not makes sense, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
