mwojtyczka commented on code in PR #63775:
URL: https://github.com/apache/airflow/pull/63775#discussion_r2980147501
##########
providers/databricks/src/airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -474,7 +500,7 @@ async def _a_get_aad_token_for_default_az_credential(self,
resource: str) -> str
DefaultAzureCredential as AsyncDefaultAzureCredential,
)
Review Comment:
`_get_connection_attr("login")` was replaced with `conn.login or ""`. Please
verify these are equivalent — `_get_connection_attr` may have additional
null-handling or logging beyond a plain attribute access. If they are
equivalent, a brief comment here would help future readers understand why the
simpler form is safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
