techcodie commented on PR #63775: URL: https://github.com/apache/airflow/pull/63775#issuecomment-4109931251
Thanks for the feedback, @amoghrajesh! I've updated the PR to adopt the comprehensive refactor you suggested, similar to #63611. Key updates: 1. **Public API Adoption**: Replaced the use of the private `_async_get_connection` with the public `BaseHook.aget_connection` for connection fetching. 2. **Robust Async Path**: Renamed the helper to `a_databricks_conn()`. All async methods now fetch the connection via this method and use the local `conn` object. This ensures no async method touches the sync property, avoiding `AsyncToSync` errors. 3. **Comprehensive Coverage**: Updated all async code paths (including 32+ accesses across async methods) to use these async alternatives, addressing the fragility mentioned earlier. 4. **Verified Local**: Verified the changes by running the full test suite for the Databricks Hook, and all 107 tests are passing locally. Ready for review and hope this can be merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
