choo121600 commented on code in PR #63447:
URL: https://github.com/apache/airflow/pull/63447#discussion_r2957820476
##########
airflow-core/src/airflow/ui/tests/e2e/pages/RequiredActionsPage.ts:
##########
@@ -77,11 +73,10 @@ export class RequiredActionsPage extends BasePage {
await button.click();
await responsePromise;
- await this.page.waitForTimeout(10_000);
}
private async clickOnTaskInGrid(dagRunId: string, taskId: string):
Promise<void> {
- const taskLocator = this.page.locator(`[id="grid-${dagRunId}-${taskId}"]`);
+ const taskLocator = this.page.getByTestId(`grid-${dagRunId}-${taskId}`);
await expect(taskLocator).toBeVisible({ timeout: 30_000 });
Review Comment:
one nit
##########
airflow-core/src/airflow/ui/tests/e2e/pages/RequiredActionsPage.ts:
##########
@@ -77,11 +73,10 @@ export class RequiredActionsPage extends BasePage {
await button.click();
await responsePromise;
- await this.page.waitForTimeout(10_000);
}
private async clickOnTaskInGrid(dagRunId: string, taskId: string):
Promise<void> {
- const taskLocator = this.page.locator(`[id="grid-${dagRunId}-${taskId}"]`);
+ const taskLocator = this.page.getByTestId(`grid-${dagRunId}-${taskId}`);
await expect(taskLocator).toBeVisible({ timeout: 30_000 });
Review Comment:
```suggestion
await expect(taskLocator).toBeVisible({ timeout: 5_000 });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
