choo121600 commented on code in PR #63447:
URL: https://github.com/apache/airflow/pull/63447#discussion_r2946356741
##########
airflow-core/src/airflow/ui/tests/e2e/pages/RequiredActionsPage.ts:
##########
Review Comment:
Could we also switch this part to use `getByRole()`?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/RequiredActionsPage.ts:
##########
Review Comment:
Could we also switch this part to use `getByRole()`?
And it seems like `.locator("..")` could be flaky since it depends on the
DOM structure — what do you think?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/RequiredActionsPage.ts:
##########
Review Comment:
Could we also switch this part to use `getByTestId()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
