o-nikolas commented on code in PR #62962:
URL: https://github.com/apache/airflow/pull/62962#discussion_r2897894877
##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio.py:
##########
@@ -78,10 +75,6 @@ def get_mwaa_environment_params(
parameters = {}
parameters[f"{AIRFLOW_PREFIX}DATAZONE_DOMAIN_ID"] = domain_id
parameters[f"{AIRFLOW_PREFIX}DATAZONE_PROJECT_ID"] = project_id
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_ENVIRONMENT_ID"] = environment_id
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_SCOPE_NAME"] = "dev"
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_STAGE"] = "prod"
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_ENDPOINT"] =
f"https://datazone.{region_name}.api.aws";
Review Comment:
> Older versions of SDK did use these parameters. But this system test is
using the latest version of SDK Airflow can get, so they will just be noops.
We regularly run the system tests against with different AMPP versions and
Airflow versions, so let's not assume too much.
> For our use-case at least, the older version of SDK can only be used with
the older version of Airflow, so I think it is fine to remove the env vars from
here.
How are you enforcing that? Did you update the minimum version of that SDK
in the pyproject toml file? I think we likely did, but let's double check that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
