o-nikolas commented on code in PR #62962:
URL: https://github.com/apache/airflow/pull/62962#discussion_r2893344371
##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio.py:
##########
@@ -78,10 +75,6 @@ def get_mwaa_environment_params(
parameters = {}
parameters[f"{AIRFLOW_PREFIX}DATAZONE_DOMAIN_ID"] = domain_id
parameters[f"{AIRFLOW_PREFIX}DATAZONE_PROJECT_ID"] = project_id
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_ENVIRONMENT_ID"] = environment_id
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_SCOPE_NAME"] = "dev"
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_STAGE"] = "prod"
- parameters[f"{AIRFLOW_PREFIX}DATAZONE_ENDPOINT"] =
f"https://datazone.{region_name}.api.aws";
Review Comment:
> these are not being actually used in SDK either so we completely removed
these in SMUS SDK recently
I'm getting mixed signals. You removed them recently, so in the past they
were being used, right? Or is it that they were never ever used in the SDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
