Copilot commented on code in PR #62811:
URL: https://github.com/apache/airflow/pull/62811#discussion_r2895568683
##########
airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts:
##########
@@ -218,8 +218,8 @@ test.describe("Backfill pause, resume, and cancel
controls", () => {
await expect(async () => {
await backfillPage.page.reload();
await expect(backfillPage.triggerButton).toBeVisible({ timeout: 10_000
});
- await expect(backfillPage.pauseButton).toBeVisible({ timeout: 5000 });
- }).toPass({ timeout: 60_000 });
+ await expect(backfillPage.pauseButton).toBeVisible({ timeout: 15_000 });
+ }).toPass({ timeout: 120_000 });
Review Comment:
The change to `backfill.spec.ts` (increasing the `pauseButton` visibility
timeout from 5 000 ms to 15 000 ms and the outer `toPass` timeout from 60 000
ms to 120 000 ms) is completely unrelated to the stated PR goal of fixing flaky
OTEL connection issues. The PR description mentions only OTEL integration test
fixes and an OTEL Collector healthcheck, but makes no mention of these
Playwright backfill E2E test timeout changes. This appears to be an unrelated
change that was bundled into this PR.
##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -212,6 +212,10 @@ def setup_class(cls):
os.environ["AIRFLOW__TRACES__OTEL_ON"] = "True"
os.environ["OTEL_EXPORTER_OTLP_PROTOCOL"] = "http/protobuf"
os.environ["OTEL_EXPORTER_OTLP_TRACES_ENDPOINT"] =
"http://breeze-otel-collector:4318/v1/traces";
+ if cls.use_otel != "true":
+ os.environ["OTEL_TRACES_EXPORTER"] = "console"
Review Comment:
Setting `OTEL_TRACES_EXPORTER=console` when `use_otel != "true"` will cause
`test_dag_execution_succeeds` (lines 441–524) to fail, because that test always
queries the Jaeger API for span data (line 497:
`requests.get(f"http://{host}:16686/api/traces?service={service_name}";)`). With
`OTEL_TRACES_EXPORTER=console`, no spans are sent to Jaeger (or via the
otel-collector), so the test will either receive an empty trace list (causing
an `IndexError` on `data["data"][-1]`) or assert against stale spans from a
prior test run.
Either this test needs a `use_otel == "true"` guard around its Jaeger
query-and-assert block, or this env var should not be set to `console` for the
span exporter when the Jaeger test expects OTLP data.
Note that the `AIRFLOW__METRICS__OTEL_ON` and `OTEL_METRICS_EXPORTER`
changes on lines 217–218 are fine, as those affect only metrics, not spans.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
