jason810496 commented on code in PR #62811:
URL: https://github.com/apache/airflow/pull/62811#discussion_r2895548910
##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -212,6 +212,10 @@ def setup_class(cls):
os.environ["AIRFLOW__TRACES__OTEL_ON"] = "True"
os.environ["OTEL_EXPORTER_OTLP_PROTOCOL"] = "http/protobuf"
os.environ["OTEL_EXPORTER_OTLP_TRACES_ENDPOINT"] =
"http://breeze-otel-collector:4318/v1/traces";
+ if cls.use_otel != "true":
+ os.environ["OTEL_TRACES_EXPORTER"] = "console"
+ os.environ["OTEL_METRICS_EXPORTER"] = "none"
Review Comment:
Should we set `OTEL_METRICS_EXPORTER` as `"console"`?
https://github.com/apache/airflow/blob/63ea296047d7e31b5c929043b11929c1484163d6/airflow-core/tests/integration/otel/test_otel.py#L830-L831
##########
airflow-core/src/airflow/ui/tests/e2e/specs/backfill.spec.ts:
##########
@@ -218,8 +218,8 @@ test.describe("Backfill pause, resume, and cancel
controls", () => {
await expect(async () => {
await backfillPage.page.reload();
await expect(backfillPage.triggerButton).toBeVisible({ timeout: 10_000
});
- await expect(backfillPage.pauseButton).toBeVisible({ timeout: 5000 });
- }).toPass({ timeout: 60_000 });
+ await expect(backfillPage.pauseButton).toBeVisible({ timeout: 15_000 });
+ }).toPass({ timeout: 120_000 });
Review Comment:
This is UI only e2e test instead of the integration test mentioning in the
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
