ryanahamilton commented on code in PR #43041:
URL: https://github.com/apache/airflow/pull/43041#discussion_r1801708143
##########
airflow/ui/src/layouts/Nav/Nav.tsx:
##########
@@ -78,29 +83,33 @@ export const Nav = () => {
icon={<FiDatabase size="1.75rem" />}
isDisabled
title="Assets"
+ to="assets"
/>
<NavButton
icon={<FiBarChart2 size="1.75rem" />}
isDisabled
title="DAG Runs"
+ to="dag_runs"
/>
<NavButton
icon={<FiGlobe size="1.75rem" />}
isDisabled
title="Browse"
+ to="browse"
/>
<NavButton
icon={<FiSettings size="1.75rem" />}
isDisabled
title="Admin"
+ to="admin"
/>
</Flex>
<Flex flexDir="column">
<NavButton
as={Link}
- href={import.meta.env.VITE_LEGACY_API_URL}
icon={<FiCornerUpLeft size="1.5rem" />}
title="Return to legacy UI"
+ to={import.meta.env.VITE_LEGACY_API_URL}
Review Comment:
Does this still work now? It looks like the `NavButton` was intended to
handle this internally but did not include the actual logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
