ryanahamilton commented on code in PR #43041:
URL: https://github.com/apache/airflow/pull/43041#discussion_r1801667405
##########
airflow/ui/src/layouts/Nav/NavButton.tsx:
##########
@@ -31,8 +31,12 @@ type NavButtonProps = {
} & ButtonProps;
export const NavButton = ({ icon, title, to, ...rest }: NavButtonProps) => (
- <Button as={RouterLink} to={to} {...navButtonProps} {...rest}>
- <Box alignSelf="center">{icon}</Box>
- <Box fontSize="xs">{title}</Box>
- </Button>
+ <Box as={NavLink} to={to ?? ""}>
Review Comment:
Yeah, the typing on this component just looks incorrect… `href` and `target`
should be removed from `NavButtonProps` and `to` should not be optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
