potiuk commented on PR #42985: URL: https://github.com/apache/airflow/pull/42985#issuecomment-2412118669
> For easier review... might be better to make some smaller incremental moves w/o any content changes, then git diff is faster to scroll through :-D Good point. And really reasonable. I tried to make it smaller, but all the necessary changes result from the move (i.e. in pretty much all files import will have to change. And then our pre-commit/formatting also intervenes. The comment from @ashb will likely limit the number of content changes. So in general we won't avoid content changes. But - yes - I could split it to several commits though if you think it help to review it - I will attempt to do it, that will be rather easy. It's also a good exercise with some git commands to produce such commits :D so let me exercise my fingers. I **could** also separate docstring fixes - dev has different rules than the "actual" code - including tests, but I figured that it's docstring only and there are not many of those - mostly empty lines and dots and changing to imperative statements in the first line. But I will see if that is easy - if not I would leave them together with the import changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
