jscheffl commented on code in PR #42985: URL: https://github.com/apache/airflow/pull/42985#discussion_r1799998472
########## providers/tests/system/airbyte/example_airbyte_trigger_job.py: ########## @@ -61,7 +61,13 @@ # Task dependency created via `XComArgs`: # async_source_destination >> airbyte_sensor -from dev.tests_common.test_utils.system_tests import get_test_run # noqa: E402 +from tests_common.test_utils.system_tests import get_test_run # noqa: E402 + +# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest) +test_run = get_test_run(dag) + + +from tests_common.test_utils.system_tests import get_test_run # noqa: E402 Review Comment: Why do you import two times here? Can the E402 be removed or is this a specific to system test? ########## providers/tests/system/airbyte/example_airbyte_trigger_job.py: ########## @@ -61,7 +61,13 @@ # Task dependency created via `XComArgs`: # async_source_destination >> airbyte_sensor -from dev.tests_common.test_utils.system_tests import get_test_run # noqa: E402 +from tests_common.test_utils.system_tests import get_test_run # noqa: E402 + +# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest) +test_run = get_test_run(dag) + + +from tests_common.test_utils.system_tests import get_test_run # noqa: E402 Review Comment: Same below repeating... so probably it is a feature, not a bug? :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org