uranusjr commented on a change in pull request #20106:
URL: https://github.com/apache/airflow/pull/20106#discussion_r764570799
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -25,10 +25,22 @@
from snowflake import connector
from snowflake.connector import DictCursor, SnowflakeConnection
from snowflake.connector.util_text import split_statements
+from sqlalchemy import create_engine
from airflow.hooks.dbapi import DbApiHook
+def _boolify(value):
+ if isinstance(value, bool):
+ return value
+ if isinstance(value, str):
+ if value.lower() == 'false':
+ return False
+ elif value.lower() == 'true':
+ return True
+ return value
Review comment:
Also we have `airflow.utils.strings.to_boolean()`. Its behaviour is
different from the one you have here, but might be more expected since the
function is used in other parts of Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
