turbaszek commented on a change in pull request #20106:
URL: https://github.com/apache/airflow/pull/20106#discussion_r764408021
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -210,19 +236,38 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:
def get_uri(self) -> str:
"""Override DbApiHook get_uri method for get_sqlalchemy_engine()"""
- conn_config = self._get_conn_params()
+ conn_params = self._get_conn_params()
+ return self._conn_params_to_sqlalchemy_uri(conn_params)
+
+ def _conn_params_to_sqlalchemy_uri(self, conn_params):
uri = (
'snowflake://{user}:{password}@{account}.{region}/{database}/{schema}'
'?warehouse={warehouse}&role={role}&authenticator={authenticator}'
)
- return uri.format(**conn_config)
+ return uri.format(**conn_params)
def get_conn(self) -> SnowflakeConnection:
"""Returns a snowflake.connection object"""
conn_config = self._get_conn_params()
conn = connector.connect(**conn_config)
return conn
+ def get_sqlalchemy_engine(self, engine_kwargs=None):
+ """
+ Get an sqlalchemy_engine object.
+
+ :param engine_kwargs: Kwargs used in :func:`~sqlalchemy.create_engine`.
+ :return: the created engine.
+ """
+ if engine_kwargs is None:
+ engine_kwargs = {}
Review comment:
```suggestion
engine_kwargs = engine_kwargs or {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
