> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3440 > > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3440> > > > > Assign a clone type of linked or full to userVmCloneType variable and > > change the value if global parameter is otherwise.
That's a good idea, will do that. > On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3441 > > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3441> > > > > > > Sateesh Chodapuneedi wrote: > Instead use getFullCloneFlag() defined in VmwareManager. Actually I had to re-read the config for this reason - The problem is that if I import com.cloud.hypervisor.vmware.manager.VmwareManager;, I get an error in eclipse that says "The import com.cloud.hypervisor.vmware cannot be resolved" - looks like there are dependency issues. Any idea how I can get over it? During compilation, this is the error : "/root/vijay/mywork/cloudstack/asf/asf-ws/incubator-cloudstack/server/src/com/cloud/vm/UserVmManagerImpl.java:[280,42] package com.cloud.hypervisor.vmware.manager does not exist". > On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3443 > > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3443> > > > > Better to declare enum for cloneType Yes that would be better - will do that. > On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3452 > > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3452> > > > > Is cleanup of the this row taken care when VM with id gets removed? I noticed that vm_instance and user_vm entries for VMs aren't removed when the VM is destroyed. So I didn't remove the entries in the new user_vm_clone_setting table either. I think it's better to retain that entry when we have an option to restore a destroyed user VM. > On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > setup/db/db/schema-40to410.sql, line 1327 > > <https://reviews.apache.org/r/9439/diff/1/?file=258730#file258730line1327> > > > > Why is the table name different from user_vm_clone_setting in > > create-schema.sql? Oh thanks for catching that! I hadn't tested upgrade path yet. Will make the required change to this file. The table name must be user_vm_clone_setting. Will update the diffs with the above modifications at the earliest. Thanks a ton for the prompt review Sateesh! > On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote: > > setup/db/create-schema.sql, line 2687 > > <https://reviews.apache.org/r/9439/diff/1/?file=258729#file258729line2687> > > > > Make this FOREIGN KEY with clause "ON DELETE SET CASCADE" to enable > > cascaded deletion of the row when the corresponding VM row is deleted in vm > > instance table. As described in the point above, I think we shouldn't be doing this.. - Venkata Siva Vijayendra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9439/#review16564 ----------------------------------------------------------- On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9439/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2013, 4:54 a.m.) > > > Review request for cloudstack and Kelven Yang. > > > Description > ------- > > Please find the diffs for full clone guest VM support for ESX on Cloudstack. > The diffs do not include unit tests yet. The tests will be uploaded at the > earliest. > > > This addresses bug CS-670. > > > Diffs > ----- > > core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java > e1ca6cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 88e03f5 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 5cac253 > server/conf/migration-components.xml 90fbafa > server/src/com/cloud/configuration/Config.java b22bf4b > server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff > server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION > server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION > setup/db/create-schema.sql 11ae267 > setup/db/db/schema-40to410.sql 7f00441 > > Diff: https://reviews.apache.org/r/9439/diff/ > > > Testing > ------- > > Manual Testing > ============== > > Creation of guest VMs when the global flag vmware.create.full.clone is set to > its default value of false will create those guest VMs as linked clones > (current default behavior without these changes). > Creation of guest VMs when the global flag vmware.create.full.clone is set to > true will create those guest VMs as full clones. > Appropriate entries are created in the user_vm_clone_setting table of the > cloud schema to reflect the clone type of the VMs. > Linked clones and full clones can reside together in the same cluster and > work as expected. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
