----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9439/#review16564 -----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9439/#comment35146> Assign a clone type of linked or full to userVmCloneType variable and change the value if global parameter is otherwise. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9439/#comment35143> server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9439/#comment35144> Better to declare enum for cloneType server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9439/#comment35147> Is cleanup of the this row taken care when VM with id gets removed? setup/db/create-schema.sql <https://reviews.apache.org/r/9439/#comment35148> Make this FOREIGN KEY with clause "ON DELETE SET CASCADE" to enable cascaded deletion of the row when the corresponding VM row is deleted in vm instance table. setup/db/db/schema-40to410.sql <https://reviews.apache.org/r/9439/#comment35149> Why is the table name different from user_vm_clone_setting in create-schema.sql? - Sateesh Chodapuneedi On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9439/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2013, 4:54 a.m.) > > > Review request for cloudstack and Kelven Yang. > > > Description > ------- > > Please find the diffs for full clone guest VM support for ESX on Cloudstack. > The diffs do not include unit tests yet. The tests will be uploaded at the > earliest. > > > This addresses bug CS-670. > > > Diffs > ----- > > core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java > e1ca6cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 88e03f5 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 5cac253 > server/conf/migration-components.xml 90fbafa > server/src/com/cloud/configuration/Config.java b22bf4b > server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff > server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION > server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION > setup/db/create-schema.sql 11ae267 > setup/db/db/schema-40to410.sql 7f00441 > > Diff: https://reviews.apache.org/r/9439/diff/ > > > Testing > ------- > > Manual Testing > ============== > > Creation of guest VMs when the global flag vmware.create.full.clone is set to > its default value of false will create those guest VMs as linked clones > (current default behavior without these changes). > Creation of guest VMs when the global flag vmware.create.full.clone is set to > true will create those guest VMs as full clones. > Appropriate entries are created in the user_vm_clone_setting table of the > cloud schema to reflect the clone type of the VMs. > Linked clones and full clones can reside together in the same cluster and > work as expected. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
