----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9247/ -----------------------------------------------------------
(Updated Feb. 13, 2013, 6:18 a.m.) Review request for cloudstack and Prachi Damle. Changes ------- Prachi, i have updated the diff. I have verified that it cleanly applies on master. I have also updated the diff to use containsKey method of the HashMap instead of iterating through the Map with iterator. Description ------- For snapshots taken from the same volume re-use the response obtained by calling listVolumes This addresses bug CLOUDSTACK-1134. Diffs (updated) ----- awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9fc581b awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java a835d8a Diff: https://reviews.apache.org/r/9247/diff/ Testing ------- 1. Create multiple snapshots from the same volume 2. Run ec2_get_all_snapshots - check CS api.log to ensure listVolumes has been called just once for every volume Thanks, Likitha Shetty
