----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9247/#review16490 -----------------------------------------------------------
Likitha, This patch does not apply cleanly on latest master. Can you check and submit again? Also, instead of iterating through the volumeIdSet Map, you could have just checked if the volumeId is present using containsKey method of the HashMap. - Prachi Damle On Feb. 1, 2013, 11:22 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9247/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 11:22 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > For snapshots taken from the same volume re-use the response obtained by > calling listVolumes > > > This addresses bug CLOUDSTACK-1134. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af > > Diff: https://reviews.apache.org/r/9247/diff/ > > > Testing > ------- > > 1. Create multiple snapshots from the same volume > 2. Run ec2_get_all_snapshots - check CS api.log to ensure listVolumes has > been called just once for every volume > > > Thanks, > > Likitha Shetty > >
