On Wed, Feb 06, 2013 at 11:38:37PM +0530, Koushik Das wrote: > Chip, > > I get your point. But what this essentially means is that the effective > cut-off date for all non-committers is at least a week (assumption is there > will be 2-3 iterations each taking 2 days and committers themselves will be > busy) before the actual one. Either this needs to be clearly communicated for > future releases OR another option is to let selective patches in based on > state of the code and consensus in the community. > > -Koushik
Yes, that's essentially what it means to me too, but we had plenty of reviews that were posted more than a week before the feature freeze that nobody bothered to review. So having a date is useful, but getting concensus and support to get a patch reviewed and committed is much more important in practical terms. BTW - we always have the option of doing anything we want with community concensus. If anyone feels strongly about including specific patches from reviewboard in 4.1, you are absolutely free to propose that!
