Chiradeep, I sucked this into a development branch. I pulled master into that and he just sent me a patch that fixes it.
On Fri, Jan 18, 2013 at 5:04 PM, Chiradeep Vittal <chirade...@gmail.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9011/ > > Can you rebase against current master? > > > - Chiradeep > > On January 17th, 2013, 7:38 p.m., Brian Angus wrote: > Review request for cloudstack and Marcus Sorensen. > By Brian Angus. > > *Updated Jan. 17, 2013, 7:38 p.m.* > Description > > This needs to be used to create a new feature branch. > > Feature Spec: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Add+Remove+Networks+to+VMs > Jira Request: https://issues.apache.org/jira/browse/CLOUDSTACK-645 > > Added addNicToVirtualMachine, removeNicFromVirtualMachine, and > updateDefaultNicForVirtualMachine api commands. > > Testing > > This was tested and works on devcloud and devcloud-kvm. I plan to add some > automated tests as well. > > *Bugs: * CLOUDSTACK-645 > Diffs > > - api/src/com/cloud/vm/UserVmService.java (b1ebe10) > - api/src/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java > (PRE-CREATION) > - api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java > (PRE-CREATION) > - > api/src/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java > (PRE-CREATION) > - client/tomcatconf/commands.properties.in (182cbd8) > - server/src/com/cloud/network/NetworkManagerImpl.java (0a1fcd7) > - server/src/com/cloud/vm/UserVmManagerImpl.java (a6fbdb1) > - server/src/com/cloud/vm/VirtualMachineManager.java (4f04617) > - server/src/com/cloud/vm/VirtualMachineManagerImpl.java (4d94fc5) > - server/test/com/cloud/vm/MockUserVmManagerImpl.java (27508b1) > - server/test/com/cloud/vm/MockVirtualMachineManagerImpl.java (6723198) > > View Diff <https://reviews.apache.org/r/9011/diff/> >
