It sounds like a good plan to leave 645 as is, and do the ENI compatibility as follow on work. As Chiradeep points out, that will be a fair bit more work than is in scope for 645 plus being able to add/remove NICs from existing VMs is a great extra feature on its own.
As far as API strategy/evolution goes, I guess this would boil down to a first step of adding the attach/detach NIC commands as part of 645 and then the follow on work would add create/destroy/list NIC commands. -----Original Message----- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: 10 January 2013 19:07 To: cloudstack-dev@incubator.apache.org Subject: Re: [DISCUSS] add/remove NIC on VM That would be great. We'll put the code in a feature branch and you can look at it and help us make any adjustments. Brian has been spending a lot of time on it, and I've wanted him to have credit for that by submitting to reviews.apache.org, once that happens we can create a branch for it. I think the proposal is a bit out of scope of 645 as it's more about making NICs their own entity like volumes are (and potentially entailing all of the extras Chiradeep mentions), whereas 645 is much simpler, its about modifying a VM that is already deployed rather than having to recreate it to get a network you want, but ultimately yours is a better long term method. I am wondering if it would be best to leave this particular feature 645 as-is, and then take on a separate effort to make NICs into standalone resources and pull in all of those other associated features. 645 would be a subset of the proposed functionality without really hindering us from moving on to the better solution. Alternatively we can drop 645 or make it a child of the bigger effort and just work toward it for 4.2. On Thu, Jan 10, 2013 at 11:45 AM, Chiradeep Vittal < chiradeep.vit...@citrix.com> wrote: > +1 on ENI-compatibility. > Note that there is more than just CLOUDSTACK-645 > - with ENI you can have multiple Ips per ENI > - with ENI the security group is attached to the nic instead of the vm > - there's additional APIs obviously to manage the lifecycle. > > On 1/10/13 8:36 AM, "Simon Waterhouse" > <simon.waterho...@eu.citrix.com> > wrote: > > >There is an issue > >https://issues.apache.org/jira/browse/CLOUDSTACK-645 to add/remove a network > >on VM. > > > >I would like to alter the interface proposed so we instead add > >methods to explicitly create/destroy a NIC and attach/detach it from > >a VM - the feature would then be directly analogous to the AWS > >Elastic Network Interface. > > > >I am a newcomer to CloudStack development, but I would be happy to > >take on some work in this area (write feature spec, implement API > >methods > >etc.) to build upon the work contributed by Marcus and team - from > >what I can see from CLOUDSTACK-645 much of the required functionality > >is already in place; I am just suggesting we expose it in a slightly > >different way... > > > >Regards > >Simon > >
