----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8809/#review15066 -----------------------------------------------------------
Verified the build and checked if the jars have any imports that AWSAPI uses. Looks good to me. - Likitha Shetty On Jan. 3, 2013, 5:46 p.m., Noa Resare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8809/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 5:46 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Oh maven *sigh*. The combination of a system of transitive dependencies and > the ability of pom files to inject (broken) repository information into the > lookup process sometimes result in a situation where maven attempts to > download artefacts from the wrong server. This typically happens over and > over again and slows down maven runs significantly. > > This is even more annoying when the artefacts downloaded most certainly isn't > used. > > The attached patch fixes three such problems that I can reproduce locally. > The pattern of adding excludes elements to maven dependency references is > already used in cloudstack. Newer versions of the dependencies removed are > added in other ways to the cloudstack dependency graph. > > > Diffs > ----- > > awsapi/pom.xml 2e42655 > > Diff: https://reviews.apache.org/r/8809/diff/ > > > Testing > ------- > > > Thanks, > > Noa Resare > >