----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/#review14711 -----------------------------------------------------------
Thanks for your patch, but your changes are not applying cleanly and will break both api_refactoring and javelin. I will have to merge the api_refactoring branch soon else there will be pile of review with a lot of merge conflicts. My target was to merge api_refactoring yesterday but I thought I would fix some more stuff before I merge it on master so it won't break anything on master. If you already working on some other unit tests pl. work on the api_refactoring branch, I'm planning to send a merge request and progress report on dev ML this weekend. - Rohit Yadav On Dec. 12, 2012, 10:56 a.m., Meghna Kale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8545/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:56 a.m.) > > > Review request for cloudstack, Chip Childers, Prasanna Santhanam, mice xia, > Chiradeep Vittal, and Alex Huang. > > > Description > ------- > > Added Unit test cases for com.cloud.api.commands > > > Diffs > ----- > > api/src/com/cloud/api/commands/CreateFirewallRuleCmd.java 937e9aa > api/src/com/cloud/api/commands/CreateIpForwardingRuleCmd.java a688d13 > api/src/com/cloud/api/commands/CreateLBStickinessPolicyCmd.java c2410c8 > api/src/com/cloud/api/commands/CreateLoadBalancerRuleCmd.java 80a8684 > api/src/com/cloud/api/commands/CreateNetworkACLCmd.java 033a496 > api/src/com/cloud/api/commands/CreatePortForwardingRuleCmd.java 3f3915a > api/src/com/cloud/api/commands/CreatePrivateGatewayCmd.java c56f9af > api/test/src/com/cloud/api/commands/test/CreateDiskOfferingCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateFirewallRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateIpForwardingRuleCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreateLBStickinessPolicyCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateLoadBalancerRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkACLCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkOfferingCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePhysicalNetworkCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePodCmdTest.java PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreatePortForwardingRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePrivateGatewayCmdTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8545/diff/ > > > Testing > ------- > > > Thanks, > > Meghna Kale > >
