> On Dec. 13, 2012, 2:27 p.m., Chip Childers wrote: > > Megnha, > > > > You are making a number of changes to the command classes. Can you please > > provide a description of why each change is needed before we apply this > > patch?
Chip, The changes in the command classes are done to handle scenarios where the data returned is null or empty. I did it considering negative scenario for testing. Please let me know , if you want me to add a comment for the change in the command files. - Meghna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/#review14428 ----------------------------------------------------------- On Dec. 12, 2012, 10:56 a.m., Meghna Kale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8545/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:56 a.m.) > > > Review request for cloudstack, Chip Childers, Prasanna Santhanam, mice xia, > Chiradeep Vittal, and Alex Huang. > > > Description > ------- > > Added Unit test cases for com.cloud.api.commands > > > Diffs > ----- > > api/src/com/cloud/api/commands/CreateFirewallRuleCmd.java 937e9aa > api/src/com/cloud/api/commands/CreateIpForwardingRuleCmd.java a688d13 > api/src/com/cloud/api/commands/CreateLBStickinessPolicyCmd.java c2410c8 > api/src/com/cloud/api/commands/CreateLoadBalancerRuleCmd.java 80a8684 > api/src/com/cloud/api/commands/CreateNetworkACLCmd.java 033a496 > api/src/com/cloud/api/commands/CreatePortForwardingRuleCmd.java 3f3915a > api/src/com/cloud/api/commands/CreatePrivateGatewayCmd.java c56f9af > api/test/src/com/cloud/api/commands/test/CreateDiskOfferingCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateFirewallRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateIpForwardingRuleCmdTest.java > PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreateLBStickinessPolicyCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateLoadBalancerRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkACLCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreateNetworkOfferingCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePhysicalNetworkCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePodCmdTest.java PRE-CREATION > > api/test/src/com/cloud/api/commands/test/CreatePortForwardingRuleCmdTest.java > PRE-CREATION > api/test/src/com/cloud/api/commands/test/CreatePrivateGatewayCmdTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8545/diff/ > > > Testing > ------- > > > Thanks, > > Meghna Kale > >
