Hi Hugo, Sorry, wasn't aware of Nicira case when put the fix. Both UI and API has to be fixed - don't accept vnet parameter in both create/update physicalNetwork when isolation type is not VLAN. The check should be done on the services layer before checkGuestVnetsConflicts() method is even called.
-Alena. On 10/5/12 2:41 PM, "Hugo Trippaers" <htrippa...@schubergphilis.com> wrote: >Hey Alena, > >I just ran into a problem where the fix you pushed on for CLOUDSTACK-226 >(commit 11fe086adab8e790018343252ed08aac9a27b1c6) breaks a typical >deployment scenario for Nicira > based networks. A Nicira NVP user does not need vlans so should use the >vlan range item during the setup of the physical network. With your fix >this causes a NPE. > >I¹ve filed two bugs for this: >CLOUDSTACK-270 >Ui should not ask for a vlan range if the physical network isolation type >is not VLAN <https://issues.apache.org/jira/browse/CLOUDSTACK-270> >CLOUDSTACK-271 >updatePhysicalNetwork dies with an NPE when the vlan range is empty ><https://issues.apache.org/jira/browse/CLOUDSTACK-271> > >I¹ll pick them up and fix them, but I think it¹s good to be aware that >any vlan code should only run if vlans are actually in use. > >Cheers! > >Hugo > > > > >
