----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7459/ -----------------------------------------------------------
Review request for cloudstack. Description ------- When a host has maintenance cancelled, it runs a StopCommand for every instance that was migrated off prior to enabling maintenance. This can delete patch disks for the system VMs while they're running on other hosts. This patch keeps us from deleting patch disks via StopCommand (partially reverting back to 3.0.x behavior). Diffs ----- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 22b149f Diff: https://reviews.apache.org/r/7459/diff/ Testing ------- Previously saw this for every instance previously running on host when executing cancel maintenance: 2012-10-05 16:01:24,510 DEBUG [cloud.agent.Agent] (agentRequest-Handler-1:null) Processing command: com.cloud.agent.api.StopCommand 2012-10-05 16:01:24,795 DEBUG [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) requested delete disk /dev/vg0/r-37-VM-patchdisk Post patch when I cancel maintenance, I see the stop command but no 'requested delete disk' for patchdisk. Thanks, Marcus Sorensen
