My apologies for delaying this. I reviewed the change. I don't think it should hold up the release though. The review changes are pretty minimum and really only affects developers.
The one change that is absolutely required is what Chip talked about. We need to add mysql connector rpm dependency to cloudstack's rpm. QA can test by adding the connector themselves for now but release can't go out without that. --Alex > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, August 31, 2012 5:42 AM > To: cloudstack-dev@incubator.apache.org > Cc: Alex Huang; Rajesh Battala; David Nalley > Subject: Re: [ASFCS40] Help needed to resolve the mysql-connector blocker > issue > > On Thu, Aug 23, 2012 at 12:18 PM, Pradeep Soundararajan > <pradeep.soundarara...@citrix.com> wrote: > > Hi Alex, > > > > Yes, did some reworking to move the same to build-cloud.properties. It > took some time to complete. > > > > If you wish to use mysql-connector "ant build-all deploydb", then please > follow the steps: > > > > 1) Install the latest mysql-connector to the desired location (untar > > it) wget > > http://dev.mysql.com/get/Downloads/Connector-J/mysql-connector-java- > 5. > > 1.21.tar.gz/from/http://cdn.mysql.com/ > > (or) download it from "git clone > > ssh://<user-name>/var/lib/git/citrix-3p-deps.git" ( I have created two > > versions of mysql-connector, they are mysql-connector-java-5.1.7 and > > mysql-connector-java-5.1.21) > > > > 2) Set "MYSQL_CONNECTOR=/path-of-your-download-mysql-java- > connector/mysql-connector-java-xxxx-bin.jar" in 'build/build- > cloud.properties' file. > > > > 3) Apply the patch in ASF master which I have sent (Please review before > applying it): https://reviews.apache.org/r/6752/ > > build/build-cloud.properties: > 552de7f74db7b715da70cc48ff4dc8945fa066f8 > > build/developer.xml: f2e5aa6463ec849a3e97343e82423ff0ac622222 > > setup/db/deploy-db-dev.sh: > > f149e9efd029bd311b1d247e21764b9103fd01d9 > > > > 4) Permanently remove David Nalley's below change rather than > commenting out from developer.xml. > > > > commit 16437df9bdb2fdc13f317c338262d433365fbfdc > > Author: David Nalley <da...@gnsa.us> > > Date: Mon Aug 20 14:19:37 2012 -0400 > > > > commenting out the copy statement for mysql-connector-java so the > > test doesn't break > > > > 5) Execute: "ant build-all deploy-server deploydb unittest" > > > > Please let me know your comments... > > > > Thanks, > > Pradeep.S > > Hi folks, > > Has anyone circled back to test / review Pradeep's suggestions? I was going > to start working on the JUnit build failures on jenkins.cloudstack.org, but I > realized that this isn't wrapped up yet. > I personally consider this a blocker to the release, but I think it would be > best > if we completed the review before it's brought into master. > > Alex - Do you have time to review this today? > > -chip
