On Fri, Aug 31, 2012 at 8:46 AM, Hugo Trippaers <htrippa...@schubergphilis.com> wrote: > Hey Chip, > > I did a quick fix to get the build working again, just pushed the commit to > master. The mysql connector rpm is already installed on the Jenkins server, I > just modified the scripts to it is picked up by the build.
That did clear the Jenkins build... thanks! > The problem will also be going away when we start to use maven as we can pull > the mysql connector in as a dependency automagically. So help me understand that one. IIRC, we need mysql-connector to be a system dependency. So the maven build can certainly pull it in as a dependency during the build, but it can't be in our convenience binary bundles that we publish. The other requirement for "system dependencies" as ASF (again IIRC), is that the user has to take explicit action to have it installed. We can't automatically pull it in for them, due to it's license type. I think it needs to be set as a package dependency within the spec and deb files, so the package installation process will resolve it as a dependency on the user's system. > Cheers, > > Hugo > > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, August 31, 2012 2:42 PM > To: cloudstack-dev@incubator.apache.org > Cc: Alex Huang; Rajesh Battala; David Nalley > Subject: Re: [ASFCS40] Help needed to resolve the mysql-connector blocker > issue > > On Thu, Aug 23, 2012 at 12:18 PM, Pradeep Soundararajan > <pradeep.soundarara...@citrix.com> wrote: >> Hi Alex, >> >> Yes, did some reworking to move the same to build-cloud.properties. It took >> some time to complete. >> >> If you wish to use mysql-connector "ant build-all deploydb", then please >> follow the steps: >> >> 1) Install the latest mysql-connector to the desired location (untar >> it) wget >> http://dev.mysql.com/get/Downloads/Connector-J/mysql-connector-java-5. >> 1.21.tar.gz/from/http://cdn.mysql.com/ >> (or) download it from "git clone >> ssh://<user-name>/var/lib/git/citrix-3p-deps.git" ( I have created two >> versions of mysql-connector, they are mysql-connector-java-5.1.7 and >> mysql-connector-java-5.1.21) >> >> 2) Set >> "MYSQL_CONNECTOR=/path-of-your-download-mysql-java-connector/mysql-connector-java-xxxx-bin.jar" >> in 'build/build-cloud.properties' file. >> >> 3) Apply the patch in ASF master which I have sent (Please review before >> applying it): https://reviews.apache.org/r/6752/ >> build/build-cloud.properties: >> 552de7f74db7b715da70cc48ff4dc8945fa066f8 >> build/developer.xml: f2e5aa6463ec849a3e97343e82423ff0ac622222 >> setup/db/deploy-db-dev.sh: >> f149e9efd029bd311b1d247e21764b9103fd01d9 >> >> 4) Permanently remove David Nalley's below change rather than commenting >> out from developer.xml. >> >> commit 16437df9bdb2fdc13f317c338262d433365fbfdc >> Author: David Nalley <da...@gnsa.us> >> Date: Mon Aug 20 14:19:37 2012 -0400 >> >> commenting out the copy statement for mysql-connector-java so the >> test doesn't break >> >> 5) Execute: "ant build-all deploy-server deploydb unittest" >> >> Please let me know your comments... >> >> Thanks, >> Pradeep.S > > Hi folks, > > Has anyone circled back to test / review Pradeep's suggestions? I was going > to start working on the JUnit build failures on jenkins.cloudstack.org, but I > realized that this isn't wrapped up yet. > I personally consider this a blocker to the release, but I think it would be > best if we completed the review before it's brought into master. > > Alex - Do you have time to review this today? > > -chip >
