On 04/08/2012, at 12:16 PM, Ewan Mellor <ewan.mel...@eu.citrix.com> wrote:
>> What happens if there's a rockstar NetScaler developer lurking here - how do >> they get involved in that? What if the people buddy-coding are working on >> the same feature as someone that doesn't work with them - how will they >> collaborate? > > My point wasn't that people won't be collaborating. My point was that by the > time things land in master, they may have multiple authors associated with > them. The people working on this branch have been prototyping, making > mistakes along the way, and keeping up with changes in the systems that > they're talking to. And while all that has been going on, master has been > moving forward at a great lick. But where will they collaborate, in an inclusive manner, if not in the ASF repo and list, with the usual project patch submission mechanism? > > By the time the feature lands in master, we're not going to see all those > prototypes and mistakes, because it would be impossible to merge them all by > now, and we certainly don't want to review changes that are wrong. We're > going to see a small number of clean changesets that apply against HEAD. > That's what we will be reviewing for submission into master. That's part of the problem I see with this - the thought processes, prototypes and even mistakes are helpful for others to understand why something ended up the way it did. Early review is far more effective than reviewing a large final commit if you have suggestions, especially if they are fundamental to the change. All that information is useful to keep in the ASF repository history. > > The consequence of that is that a single changeset will have multiple > authors. This is what happened to Vijay B the other day -- he turned up with > a sanitized, ready-for-merge changeset, and he got shouted at for submitting > someone else's code. We have to figure out how to handle this. Telling him > to go away isn't going to work. Let's be clear - no one is being shouted at, and no one is being told to go away - quite the opposite. I certainly apologise if I've come off that way. It is important for all the committers to be on board with how this is handled going forward, so I'd appreciate hearing some of their opinions on it. - Brett
