On Jul 31, 2012, at 4:36 PM, Wido den Hollander wrote: > On 07/31/2012 10:24 PM, sebgoa wrote: >> Hi, >> >> Since I am new to Cloudstack and Apache like projects, I was looking at the >> process for submitting a very small patch (e.g typo, one-liner, license >> header) > > Always welcome! > >> >> The wiki page on how to use git o contribute to Cloudstack has a section for >> non-committer: >> >> http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world#Gitworkflowinthebravenewworld-Non-committerworkflow >> >> This is a bit confusing to me, so I would like to get some feedback from the >> more seasoned developper and committers: >> >> 1-Does every patch needs to be submitted in response to a filed bug ? > > No, I don't think it needs to. If it's a trivial typo fix it's not needed. > >> 2-Do we got through https://reviews.apache.org ?
So Non-committers don't need to get an account on RB and submit patches via that path ? >> 3-The wiki mentions sending the patch to dev mailing list with subject >> [PATCH] but that's not what I have seen in the last few weeks ? > > Committers don't need to sent their patches over the dev mailinglist. We > haven't seen much external code lately. > >> 4-What's the best way to use git to prepare a small patch (e.g docs typo, >> one-liner ...etc), do we really need to create a branch ? how does it get >> resolved locally once the patch is accepted ? > > Yes, you still have to branch. The commands: > > $ git clone https://git-wip-us.apache.org/repos/asf/incubator-cloudstack.git > $ git checkout -b typo-fix > $ vi/nano/vim <file to fix> > $ git commit <file to fix> > $ git format-patch -s master > $ git send-email newly-generated-patch-0001.patch > > Somebody with commit access will pick up that patch and apply if it's > acceptable. > > Wido > >> >> It would be nice to agree on a clear worfklow for non-committers (and >> newbies like me) so we can get some people in the mix and graduate to >> committers... >> >> Thoughts anyone ? >> >> Thanks, >> >> -Sebastien Goasguen >> Apache Cloudstack Evangelist >> https://sites.google.com/site/runseb/ >> >>
