----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5839/#review9416 -----------------------------------------------------------
Ship it! Fix is good. The code for addNetworkServiceProvider API makes sure only one provider of a given name exists on a physical network. - Prachi Damle On July 9, 2012, 6:44 p.m., Hugo Trippaers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5839/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 6:44 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > While running some test scripts I noticed that the table > 'physical_network_service_providers' has a unique key on the combination of > physical_network_id and provider_name, this is potentially a problem when we > also use the removed field to indicate a device is removed. > > As Alex indicated this is a bug and here is a proposed fix. > > > Diffs > ----- > > setup/db/create-schema.sql c2efb27 > > Diff: https://reviews.apache.org/r/5839/diff/ > > > Testing > ------- > > Removed the constraint and added a new device, works and a list devices shows > only one device. > > > Thanks, > > Hugo Trippaers > >
