Agreed, I'll more than happy to put it in, but I don't know where exactly.
-----Original Message----- From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com] Sent: Monday, July 09, 2012 8:48 PM To: cloudstack-dev@incubator.apache.org; Hugo Trippaers Subject: Re: Review Request: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field. DataBase upgrade part of the code should be fixed as well. For all existing customers this key has to be dropped as a part of the upgrade. -Alena. On 7/9/12 11:44 AM, "Hugo Trippaers" <htrippa...@schubergphilis.com> wrote: > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/5839/ >----------------------------------------------------------- > >(Updated July 9, 2012, 6:44 p.m.) > > >Review request for cloudstack. > > >Description >------- > >While running some test scripts I noticed that the table >'physical_network_service_providers' has a unique key on the >combination of physical_network_id and provider_name, this is >potentially a problem when we also use the removed field to indicate a device >is removed. > >As Alex indicated this is a bug and here is a proposed fix. > > >Diffs >----- > > setup/db/create-schema.sql c2efb27 > >Diff: https://reviews.apache.org/r/5839/diff/ > > >Testing >------- > >Removed the constraint and added a new device, works and a list devices >shows only one device. > > >Thanks, > >Hugo Trippaers > >
