Alex, Would you also like general feedback at the pragprog.com url? Or is that better here?
Aria Media Sagl Via Rompada 40 6987 Caslano Switzerland +41 (0)91 600 9601 +41 (0)76 303 4477 cell skype: ariamedia On Mon, Apr 13, 2015 at 3:16 PM, Alex Miller <a...@puredanger.com> wrote: > Thanks Mohit! > > There was a bug around this that I had fixed at one point, perhaps I > didn't get that change applied. BTW, for future "bugs" on the book, it's > best to file them here so we can track them: > https://pragprog.com/titles/vmclojeco/errata > > Alex > > > On Sunday, April 12, 2015 at 1:28:03 AM UTC-5, Mohit Thatte wrote: >> >> Alex >> >> I read the preview chapters, great read so far. Looking forward to the >> whole book. >> >> There seems to be a small error in the Value Based Dispatch section on >> page 8, where the comments don't match the code. oz and lb seem to be >> flipped! >> >> (defmulti convert >>> "Convert quantity from unit1 to unit2, matching on [unit1 unit2]" >>> (fn [unit1 unit2 quantity] [unit1 unit2])) >>> >>> ;; lb to oz >>> (defmethod convert [:lb :oz] [_ _ oz] (* oz 16)) >>> >>> ;; oz to lb >>> (defmethod convert [:oz :lb] [_ _ lb] (/ lb 16)) >>> >> >> >> Cheers, >> Mohit >> >> On Saturday, April 11, 2015 at 6:35:05 AM UTC+5:30, Alex Miller wrote: >>> >>> Great to hear! >> >> -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
