Yes, ArrayList is a particularly common case (see http://insideclojure.org/2015/01/07/vec-perf/). I'm going to reinstate the prior one though, no reason to break people (even if they are using an internal method).
On Monday, January 12, 2015 at 3:59:09 AM UTC-6, Mikera wrote: > > It seems a little odd that there is an "ArrayList" override but not > "List". Presumably that is there as an optimisation since ArrayList is such > a common case? > > It seems to have happened in this commit for CLJ-1546, which replaces the > "List" override with "ArrayList" > > https://github.com/clojure/clojure/commit/4afd4a7c14c48b5baf3c03196053066483cb4223 > > I'd probably recommend keeping the old "List" override around: it is more > general, potentially useful for Interop and will help avoid breakage like > this (even if it is just an implementation detail). > > On Monday, 12 January 2015 17:43:09 UTC+8, Rangel Spasov wrote: >> >> Hey guys, >> >> I noticed that PersistentVector.create() is missing one arity that used >> to exist before: >> >> PersistentVector.create(List items) >> >> ... which caused this library >> https://github.com/ninjudd/clojure-protobuf/blob/develop/src/flatland/protobuf/PersistentProtocolBufferMap.java#L479 >> >> to throw >> >> NoSuchMethodError >> clojure.lang.PersistentVector.create(Ljava/util/List;)Lclojure/lang/PersistentVector; >> >> >> I can fix the library, I don't think it will be a big problem, just >> making sure that's something you guys were OK with breaking - it's more >> like an implementation detail as far as I can see. >> >> Thanks, >> Rangel >> @raspasov >> >> On Sunday, January 11, 2015 at 6:34:07 AM UTC-8, Alex Miller wrote: >>> >>> I would greatly appreciate hearing any feedback about this (or any >>> other) alpha, even if it's just: everything looks ok. >>> >>> We've had a couple of regressions reported and that is hugely helpful as >>> we can quickly turn around fixes for the next one. >>> >>> Interested particularly in: regressions, performance +/-, and for this >>> alpha, AOT. >> >> -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
