> > > Yes, resultset-seq does lowercase the column names and it doesn't > translate between - / _ either. But that's not part of c.j.j so, > whilst I may agree with the criticisms of it, I can't actually fix > that :) > > There is justification for resultset-seq's current behaviour, even if it isn't to everyone's preference.
Down-casing the column names ensures that comparisons done in clojure are done without regard to case, just as they would be in SQL. For example, queries of two views can be joined in clojure, even if the author of the view hasn't deliberately matched the case of all the column names. Typically I find queries and views are not consistent in case because in SQL there is no requirement for them to be. I don't want to have to convince database people to change their code because I'm using a 'weird' tool to process the results. > I don't want to make a breaking change to the existing API, but in a world > there there is an actively-maintained clojure.java.jdbc I don't think a > resultset function in core makes a lot of sense anyway. > > How about we mark core's resultset-seq as deprecated, with a link to the > new project? Then c.j.j. can do a better resultset-seq, and we will leave > the old fn in core for at least on major release cycle. > I use resultset-seq everywhere. I don't mind us deprecating it, if a better version is available elsewhere (but please allow the option of down-casing); but is there really any need to remove a working function from core? I'm not keen on introducing gratuitous back-compat issues. Can we arrange for the deprecated core version to call the c.j.j version, passing any options to preserve current behaviour as much as possible, and to fail at runtime if that library is not present? -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
