Hmm, looks like I broke some logic when I hand unrolled the original cl-format based dispatch to get better performance for lists, vectors, and maps. (Really I shouldn't have to do this, but I need to make cl-format itself generate code rather than threaded functions which are slow and tend to blow your stack. Haven't gotten around to that yet, though so the hand-coded versions are stop-gaps.)
I'm not digging the patch too much, though, for 3 reasons: 1) It breaks sets and arrays, which work in master. 2) It pushes the logic for *print-length* printing into the dispatch functions (redundantly since there's still logic in write-out). Since these are customizable, it places that load on whoever customizes it. 3) It adds redundant logic in write-out which is the called for every object that the pretty printer deals with. I'll try to take a stab at a patch that fits a little better with what I'm trying to do in the next couple of days. Tom On Sat, Dec 18, 2010 at 1:18 PM, Stuart Halloway <stuart.hallo...@gmail.com>wrote: > > The latter is easy to fix: provide a version of println that wraps an > > implicit (take n ...) around seq arguments (including when it calls > > itself on seqs nested within other structures). (*print-length* > > doesn't seem to work, just causes an infinite seq to print the first n > > items and then a never-ending string of "..."s.) > > Hi Ken, > > In my tests *print-length* works fine with the regular REPL printer, but > has the defect you describe when using pprint. Can you confirm that you are > also seeing the problem with pprint, not print? > > Do some REPLs automatically replace print with pprint? > > Tom: I have created a ticket with a partial fix and would appreciate your > input: http://dev.clojure.org/jira/browse/CLJ-695. > > Thanks, > Stu > > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
