On Mon, 9 Mar 2026 20:28:46 GMT, Alexey Ivanov <[email protected]> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Address review comments
>
> test/jdk/java/awt/TextComponent/CorrectTextComponentSelectionTest.java line 
> 115:
> 
>> 113:             loc = p;
>> 114:             color_center = r.getPixelColor(loc.x, loc.y);
>> 115:         });
> 
> In this case, the assignment to `loc` and the field itself aren't needed.

Thanks, updated.

> test/jdk/java/awt/TextComponent/CorrectTextComponentSelectionTest.java line 
> 119:
> 
>> 117:         System.out.println("Color of the text component (CENTER) = "
>> 118:                 + color_center);
>> 119:         System.out.println("White color= " + Color.WHITE);
> 
> I'd rather not wrap the first `println` statement, even if it doesn't fit in 
> 80 columns; wrapping this doesn't add clarity, you'd guess what it prints 
> even if the reference is hidden.
> 
> For consistency, add space around `=`—`"White color = "`—if you decide to 
> still touch these lines.

Sure, updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30058#discussion_r2907966346
PR Review Comment: https://git.openjdk.org/jdk/pull/30058#discussion_r2907965828

Reply via email to