On Mon, 9 Mar 2026 20:31:38 GMT, Damon Nguyen <[email protected]> wrote:
>> This test used to intermittently fail. Since then, the test has been
>> converted from an `.html` test to a `.java` test. I have run the test in CI
>> on 3 different runs with 100 repeats across all OS's. The test passes on all
>> instances. So, I have removed the test from the ProblemList as well. The
>> test updates are mostly minor nits.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address review comments
test/jdk/java/awt/TextComponent/CorrectTextComponentSelectionTest.java line 115:
> 113: loc = p;
> 114: color_center = r.getPixelColor(loc.x, loc.y);
> 115: });
In this case, the assignment to `loc` and the field itself aren't needed.
test/jdk/java/awt/TextComponent/CorrectTextComponentSelectionTest.java line 119:
> 117: System.out.println("Color of the text component (CENTER) = "
> 118: + color_center);
> 119: System.out.println("White color= " + Color.WHITE);
I'd rather not wrap the first `println` statement, even if it doesn't fit in 80
columns; wrapping this doesn't add clarity, you'd guess what it prints even if
the reference is hidden.
For consistency, add space around `=`—`"White color = "`—if you decide to still
touch these lines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30058#discussion_r2907770853
PR Review Comment: https://git.openjdk.org/jdk/pull/30058#discussion_r2907794853
