On Fri, 11 Feb 2022 01:55:53 GMT, lawrence.andrews <d...@openjdk.java.net> 
wrote:

>> 1) Removed =yesno that was causing the test to fail with following exception
>> test result: Error. Parse Exception: Arguments to `manual' option not 
>> supported: yesno
>> After removing =yesno, test was just passing without user interaction so 
>> fixed the following
>> 
>> Add the following so that user can user interact with the test
>> a) Added pass/fail button and instruction for the user to know what he/she 
>> is going to test and what is expected.
>> b) Added Dialog with textarea to enter the reason for the testcase failure. 
>> This will help the user to understanding the reason why the test was failed 
>> while analyzing the results. 
>> 
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fixed review comments

I have a suggestion which may make the test semi-automatic or at least help the 
tester to verify.

If the area with the rendered text can be magnified, starting from the first 
line of text and so on, it would help verify that the text is rendered as 
expected.

The black text can be verified automatically. The gray and LCD-subpixel may 
also be automated, yet it requires more work to make the detection stable.

This is out of scope for this issue but it could be another issue. What do you 
think?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7275

Reply via email to