On Thu, 10 Feb 2022 05:36:40 GMT, lawrence.andrews <d...@openjdk.java.net>
wrote:
>> 1) Removed =yesno that was causing the test to fail with following exception
>> test result: Error. Parse Exception: Arguments to `manual' option not
>> supported: yesno
>> After removing =yesno, test was just passing without user interaction so
>> fixed the following
>>
>> Add the following so that user can user interact with the test
>> a) Added pass/fail button and instruction for the user to know what he/she
>> is going to test and what is expected.
>> b) Added Dialog with textarea to enter the reason for the testcase failure.
>> This will help the user to understanding the reason why the test was failed
>> while analyzing the results.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Removed RenderingHints.VALUE_TEXT_ANTIALIAS_GASP and fixed the review
> comments
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/Graphics/TextAAHintsTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2007, 2022 Oracle and/or its affiliates. All rights
> reserved.
Suggestion:
* Copyright (c) 2007, 2022, Oracle and/or its affiliates. All rights reserved.
One more comma.
test/jdk/java/awt/Graphics/TextAAHintsTest.java line 59:
> 57: public static final CountDownLatch countDownLatch = new
> CountDownLatch(1);
> 58: private static Frame frame;
> 59: public static String failureReason;
`failureReason` should also be `volatile`.
All the fields can be `private`. You access them from this class only; nested
classes, including the static ones, have access to private members of the
surrounding class.
test/jdk/java/awt/Graphics/TextAAHintsTest.java line 199:
> 197: }
> 198:
> 199: public static void readFailedReason() {
`readFailureReason` or `getFailureReason`?
test/jdk/java/awt/Graphics/TextAAHintsTest.java line 221:
> 219:
> 220: public static void main(String[] args) throws InterruptedException,
> InvocationTargetException {
> 221: java.awt.EventQueue.invokeAndWait(TextAAHintsTest::createTestUI);
I wonder why `EventQueue` uses fully qualified class name instead of being
imported as other classes. That's fine, I'm just wondering.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7275
