Nathan Gibbs wrote: > * Nathan Gibbs wrote: >> How can I get the clamav-milter to call a virusaction scipt that accepts a >> cmd >> line argument?
[snip] > By looking at the code it appears that this common task is being implemented > in three different ways. > The clamav-milter way is definitely incompatible with the other two. Hi Nathan, The main reason the code is different is due to the fact that OnXXX executes a script (with some params) via the shell and VirusEvent does the same but additionally expands %v to the virus name. With the milter I had to face a few more issues. On one hand I decided to drop mail notifications, which suddently made VirusAction the most immediate and obvious work around. On the other hand, everything in the milter is arbitrary, unsanitized and potentially nasty. I conisdered that, for some reason, quite a few OS's/distros run the milter as root and that the old milter had security issues related to insufficient validation[1], and the decision was not to rely on the shell for executing the external scripts. At that point i could reuse the %v logic used employed by VirusEvent except that in this case I had quite a few arguments to manage and not just one. The simpler solution was to avoid % expansion and simply feed all the info I have to the invoked script. From there, the admin can do whatever s/he likes: use some params, use all of them, disregard them all. Hope that sheds some light on the code. Cheers, --aCaB [1] http://www.securityfocus.com/archive/1/477723/30/0/threaded _______________________________________________ Help us build a comprehensive ClamAV guide: visit http://wiki.clamav.net http://www.clamav.net/support/ml
