On Wed, 28 Feb 2007 11:09:16 +0100 Gianluigi Tiesi <[EMAIL PROTECTED]> wrote:
> alex wrote: > > Dears all: > > > > I have read the source code of clamav 0.90 and found a strange code in > > filetype.c. > > > > There is an expressioniIn 233 line of filetype.c : > > > > if(!iscntrl(buf[i]) && !isprint(buf[i]) && !internat[buf[i] > > & 0xff]) > > > > and this expression would ALWAYS be false. > > > > I want to know if i am wrong ? > > > > Thanks > > > I've noticed it too, in my port I have changed it to: > > if(!(iscntrl(buf[i]) || isprint(buf[i])) || !internat[buf[i] & xff]) This one is much worse because it will lead to many false nagatives with HTML and mail files. -- oo ..... Tomasz Kojm <[EMAIL PROTECTED]> (\/)\......... http://www.ClamAV.net/gpg/tkojm.gpg \..........._ 0DCA5A08407D5288279DB43454822DC8985A444B //\ /\ Wed Feb 28 14:42:47 CET 2007 _______________________________________________ http://lurker.clamav.net/list/clamav-devel.html Please submit your patches to our Bugzilla: http://bugs.clamav.net