On Thursday, February 24, 2005, at 08:15 pm, John Peacock wrote:
Nigel Horne wrote:
Please do NOT apply this without thorough checking of the knock-on effect
of scanning bounces and digest emails.
If I am not understanding the use of the cli_smagic[] construct, please forgive me. My brief skimming of the code suggests that cli_smagic[] is only used to hint the parser as to what type of file has been presented for scanning. This was just a quick way to clue the scanner into trying to scan the file as mail.
It isn't the structure of the table which is the point, you need to think about when cli_filetype() is called.
The patch may be OK, but I am warning people to do LOTS of regression testing before using in the wild and am giving clues about why.
John
-Nigel Horne
_______________________________________________ http://lurker.clamav.net/list/clamav-devel.html
