Changeset: a59b80aca1e5 for MonetDB URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=a59b80aca1e5 Added Files: sql/backends/monet5/Tests/pyapi32.sql sql/backends/monet5/Tests/pyapi32.stable.err sql/backends/monet5/Tests/pyapi32.stable.out Modified Files: clients/Tests/exports.stable.out clients/mapiclient/mclient.c gdk/ChangeLog gdk/gdk.h gdk/gdk_bbp.c monetdb5/modules/atoms/str.c sql/backends/monet5/Tests/All sql/backends/monet5/UDF/pyapi/pyapi.c sql/backends/monet5/sql_cast.c sql/backends/monet5/sql_gencode.c sql/test/BugTracker-2016/Tests/convert-function-test.Bug-3460.sql sql/test/BugTracker-2016/Tests/convert-function-test.Bug-3460.stable.err sql/test/BugTracker-2016/Tests/convert-function-test.Bug-3460.stable.err.int128 sql/test/BugTracker-2016/Tests/convert-function-test.Bug-3460.stable.out sql/test/BugTracker-2016/Tests/convert-function-test.Bug-3460.stable.out.int128 Branch: sfcgal Log Message:
merged with default diffs (truncated from 910 to 300 lines): diff --git a/clients/Tests/exports.stable.out b/clients/Tests/exports.stable.out --- a/clients/Tests/exports.stable.out +++ b/clients/Tests/exports.stable.out @@ -177,11 +177,9 @@ BAT *BATunique(BAT *b, BAT *s); BBPrec *BBP[N_BBPINIT]; void BBPaddfarm(const char *dirname, int rolemask); void BBPclear(bat bid); -void BBPcold(bat b); int BBPcurstamp(void); int BBPdecref(bat b, int logical); BAT *BBPdescriptor(bat b); -void BBPhot(bat b); int BBPin; int BBPincref(bat b, int logical); bat BBPindex(const char *nme); diff --git a/clients/mapiclient/mclient.c b/clients/mapiclient/mclient.c --- a/clients/mapiclient/mclient.c +++ b/clients/mapiclient/mclient.c @@ -1078,7 +1078,7 @@ TESTrenderer(MapiHdl hdl) strlen(s) < l || /* start or end with white space? */ my_isspace(*s) || - my_isspace(s[l - 1]) || + (l > 0 && my_isspace(s[l - 1])) || /* timezone can have embedded comma */ strcmp(tp, "timezone") == 0 || /* a bunch of geom types */ diff --git a/gdk/ChangeLog b/gdk/ChangeLog --- a/gdk/ChangeLog +++ b/gdk/ChangeLog @@ -1,6 +1,9 @@ # ChangeLog file for MonetDB # This file is updated with Maddlog +* Fri Jul 22 2016 Sjoerd Mullender <sjo...@acm.org> +- Removed unused functions BBPhot and BBPcold. + * Wed Jul 6 2016 Sjoerd Mullender <sjo...@acm.org> - Removed BATderiveTailProps and BATderiveProps. Just set the properties you know about, or use BATsettrivprop. diff --git a/gdk/gdk.h b/gdk/gdk.h --- a/gdk/gdk.h +++ b/gdk/gdk.h @@ -1620,10 +1620,6 @@ gdk_export void GDKqsort_rev(void *h, vo * @tab BBPincref (bat bi, int logical) * @item int * @tab BBPdecref (bat bi, int logical) - * @item void - * @tab BBPhot (bat bi) - * @item void - * @tab BBPcold (bat bi) * @item str * @tab BBPname (bat bi) * @item bat @@ -1724,8 +1720,6 @@ gdk_export int BBPcurstamp(void); gdk_export void BBPlock(void); -gdk_export void BBPhot(bat b); -gdk_export void BBPcold(bat b); gdk_export void BBPunlock(void); gdk_export str BBPlogical(bat b, str buf); diff --git a/gdk/gdk_bbp.c b/gdk/gdk_bbp.c --- a/gdk/gdk_bbp.c +++ b/gdk/gdk_bbp.c @@ -3229,45 +3229,6 @@ BBPtrim(size_t target) MT_lock_unset(&GDKtrimLock(i)); } -void -BBPhot(bat i) -{ - if (BBPcheck(i, "BBPhot")) { - int lock = locked_by ? MT_getpid() != locked_by : 1; - - if (lock) - MT_lock_set(&GDKswapLock(i)); - BBP_lastused(i) = BBPLASTUSED(BBPstamp() + 30000); - if (lock) - MT_lock_unset(&GDKswapLock(i)); - } -} - -void -BBPcold(bat i) -{ - if (BBPcheck(i, "BBPcold")) { - MT_Id pid = MT_getpid(); - int idx = threadmask(pid); - int lock = locked_by ? pid != locked_by : 1; - - MT_lock_set(&GDKtrimLock(idx)); - if (lock) - MT_lock_set(&GDKswapLock(i)); - /* make very cold and insert on top of trim list */ - BBP_lastused(i) = 0; - if (BBP_cache(i) && bbptrimlast < bbptrimmax) { - lastused[--bbptrimmax] = 0; - bbptrim[bbptrimmax].bid = i; - bbptrim[bbptrimmax].next = bbptrimfirst; - bbptrimfirst = bbptrimmax; - } - if (lock) - MT_lock_unset(&GDKswapLock(i)); - MT_lock_unset(&GDKtrimLock(idx)); - } -} - /* * BBPquickdesc loads a BAT descriptor without loading the entire BAT, * of which the result be used only for a *limited* number of diff --git a/monetdb5/modules/atoms/str.c b/monetdb5/modules/atoms/str.c --- a/monetdb5/modules/atoms/str.c +++ b/monetdb5/modules/atoms/str.c @@ -1586,7 +1586,7 @@ STRConcat(str *res, const str *val1, con str STRLength(int *res, const str *arg1) { - size_t l; + int l; const char *s = *arg1; if (strNil(s)) { @@ -1595,7 +1595,7 @@ STRLength(int *res, const str *arg1) } l = UTF8_strlen(s); assert(l <INT_MAX); - *res = (int) l; + *res = l; return MAL_SUCCEED; } @@ -1620,9 +1620,7 @@ STRTail(str *res, const str *arg1, const *res = GDKstrdup(str_nil); } else { if (off < 0) { - size_t l = UTF8_strlen(s); - int len = (int) l; - assert(l < INT_MAX); + int len = UTF8_strlen(s); if (len == int_nil) { *res = GDKstrdup(str_nil); diff --git a/sql/backends/monet5/Tests/All b/sql/backends/monet5/Tests/All --- a/sql/backends/monet5/Tests/All +++ b/sql/backends/monet5/Tests/All @@ -50,6 +50,7 @@ HAVE_LIBPY?pyapi26 HAVE_LIBPY?pyapi27 HAVE_LIBPY?pyapi28 HAVE_LIBPY?pyapi29 +HAVE_LIBPY?pyapi32 # should this work? #inlineUDF diff --git a/sql/backends/monet5/Tests/pyapi32.sql b/sql/backends/monet5/Tests/pyapi32.sql new file mode 100644 --- /dev/null +++ b/sql/backends/monet5/Tests/pyapi32.sql @@ -0,0 +1,25 @@ + +START TRANSACTION; + + +CREATE FUNCTION pyapi32_gentbl() RETURNS TABLE(i TINYINT) LANGUAGE PYTHON { + return { 'i': numpy.arange(100) } +}; + +CREATE FUNCTION pyapi32_function(i INTEGER) RETURNS INTEGER LANGUAGE PYTHON { + return i * 2; +}; + +CREATE FUNCTION pyapi32_function_mapped(i INTEGER) RETURNS INTEGER LANGUAGE PYTHON_MAP { + return i * 2; +}; + +CREATE TABLE integers AS SELECT * FROM pyapi32_gentbl() WITH DATA; + +SELECT pyapi32_function(i) FROM integers; +SELECT pyapi32_function(i) FROM integers WHERE i > 50; + +SELECT pyapi32_function_mapped(i) FROM integers; +SELECT pyapi32_function_mapped(i) FROM integers WHERE i > 50; + +ROLLBACK; diff --git a/sql/backends/monet5/Tests/pyapi32.stable.err b/sql/backends/monet5/Tests/pyapi32.stable.err new file mode 100644 --- /dev/null +++ b/sql/backends/monet5/Tests/pyapi32.stable.err @@ -0,0 +1,36 @@ +stderr of test 'pyapi32` in directory 'sql/backends/monet5` itself: + + +# 14:03:48 > +# 14:03:48 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set" "mapi_open=true" "--set" "mapi_port=34523" "--set" "mapi_usock=/var/tmp/mtest-44806/.s.monetdb.34523" "--set" "monet_prompt=" "--forcemito" "--dbpath=/Users/myth/opt/var/MonetDB/mTests_sql_backends_monet5" "--set" "embedded_r=yes" "--set" "embedded_py=true" +# 14:03:48 > + +# builtin opt gdk_dbpath = /Users/myth/opt/var/monetdb5/dbfarm/demo +# builtin opt gdk_debug = 0 +# builtin opt gdk_vmtrim = no +# builtin opt monet_prompt = > +# builtin opt monet_daemon = no +# builtin opt mapi_port = 50000 +# builtin opt mapi_open = false +# builtin opt mapi_autosense = false +# builtin opt sql_optimizer = default_pipe +# builtin opt sql_debug = 0 +# cmdline opt gdk_nr_threads = 0 +# cmdline opt mapi_open = true +# cmdline opt mapi_port = 34523 +# cmdline opt mapi_usock = /var/tmp/mtest-44806/.s.monetdb.34523 +# cmdline opt monet_prompt = +# cmdline opt gdk_dbpath = /Users/myth/opt/var/MonetDB/mTests_sql_backends_monet5 +# cmdline opt embedded_r = yes +# cmdline opt embedded_py = true +# cmdline opt gdk_debug = 536870922 + +# 14:03:49 > +# 14:03:49 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e" "--host=/var/tmp/mtest-44806" "--port=34523" +# 14:03:49 > + + +# 14:03:49 > +# 14:03:49 > "Done." +# 14:03:49 > + diff --git a/sql/backends/monet5/Tests/pyapi32.stable.out b/sql/backends/monet5/Tests/pyapi32.stable.out new file mode 100644 --- /dev/null +++ b/sql/backends/monet5/Tests/pyapi32.stable.out @@ -0,0 +1,397 @@ +stdout of test 'pyapi32` in directory 'sql/backends/monet5` itself: + + +# 14:03:48 > +# 14:03:48 > "mserver5" "--debug=10" "--set" "gdk_nr_threads=0" "--set" "mapi_open=true" "--set" "mapi_port=34523" "--set" "mapi_usock=/var/tmp/mtest-44806/.s.monetdb.34523" "--set" "monet_prompt=" "--forcemito" "--dbpath=/Users/myth/opt/var/MonetDB/mTests_sql_backends_monet5" "--set" "embedded_r=yes" "--set" "embedded_py=true" +# 14:03:48 > + +# MonetDB 5 server v11.24.0 +# This is an unreleased version +# Serving database 'mTests_sql_backends_monet5', using 4 threads +# Compiled for x86_64-apple-darwin15.5.0/64bit with 64bit OIDs and 128bit integers dynamically linked +# Found 8.000 GiB available main-memory. +# Copyright (c) 1993-July 2008 CWI. +# Copyright (c) August 2008-2016 MonetDB B.V., all rights reserved +# Visit http://www.monetdb.org/ for further information +# Listening for connection requests on mapi:monetdb://Marks-MacBook-Pro.local:34523/ +# Listening for UNIX domain connection requests on mapi:monetdb:///var/tmp/mtest-44806/.s.monetdb.34523 +# MonetDB/SQL module loaded +# MonetDB/Python module loaded +# MonetDB/R module loaded + +Ready. +# SQL catalog created, loading sql scripts once +# loading sql script: 09_like.sql +# loading sql script: 10_math.sql +# loading sql script: 11_times.sql +# loading sql script: 12_url.sql +# loading sql script: 13_date.sql +# loading sql script: 14_inet.sql +# loading sql script: 15_querylog.sql +# loading sql script: 16_tracelog.sql +# loading sql script: 17_temporal.sql +# loading sql script: 18_index.sql +# loading sql script: 20_vacuum.sql +# loading sql script: 21_dependency_functions.sql +# loading sql script: 22_clients.sql +# loading sql script: 23_skyserver.sql +# loading sql script: 24_zorder.sql +# loading sql script: 25_debug.sql +# loading sql script: 26_sysmon.sql +# loading sql script: 27_rejects.sql +# loading sql script: 39_analytics.sql +# loading sql script: 39_analytics_hge.sql +# loading sql script: 40_json.sql +# loading sql script: 40_json_hge.sql +# loading sql script: 41_md5sum.sql +# loading sql script: 45_uuid.sql +# loading sql script: 46_profiler.sql +# loading sql script: 51_sys_schema_extension.sql +# loading sql script: 72_fits.sql +# loading sql script: 75_storagemodel.sql +# loading sql script: 80_statistics.sql +# loading sql script: 80_udf.sql +# loading sql script: 80_udf_hge.sql +# loading sql script: 90_generator.sql +# loading sql script: 90_generator_hge.sql +# loading sql script: 99_system.sql + +# 14:03:49 > +# 14:03:49 > "mclient" "-lsql" "-ftest" "-Eutf-8" "-i" "-e" "--host=/var/tmp/mtest-44806" "--port=34523" +# 14:03:49 > + +#START TRANSACTION; +#CREATE FUNCTION pyapi32_gentbl() RETURNS TABLE(i TINYINT) LANGUAGE PYTHON { +# return { 'i': numpy.arange(100) } +#}; +#CREATE FUNCTION pyapi32_function(i INTEGER) RETURNS INTEGER LANGUAGE PYTHON { +# return i * 2; +#}; _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list