ilya-biryukov added a comment.

The extensions itself seems like a reasonable way to provide compile commands 
for the individual files. In case didChangeConfiguration does not work for you 
for some reason, happy to take a look at this change too.
One drawback of using didChangeConfiguration for compile commands is that it 
forces global invalidation, which may be a bad thing if your client tracks 
compile commands on a smaller scale and can send requests to invalidate 
individual files. However, if you're happy with it, we might get away with not 
adding yet another mechanism to pass compile commands to clangd, which is 
definitely a good thing!


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49523



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to