mclow.lists added inline comments.
================ Comment at: include/charconv:372 + + auto __len = __last - __p; + if (__value != 0 || !__len) ---------------- mclow.lists wrote: > Are you missing an edge case here? What happens if `__last == __first && > __value == 0`? > Nevermind. Apparently I can't look two lines down. Repository: rCXX libc++ https://reviews.llvm.org/D41458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits