[PATCH] D46485: Add python tool to dump and construct header maps

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: utils/hmaptool/hmaptool:1
+#!/usr/bin/env python
+
----------------
Have you checked this works with both python2 and python3?


================
Comment at: utils/hmaptool/hmaptool:81
+                        path,))
+            if strtable[-1] != '\0':
+                raise SystemExit("error: %s: invalid string table in 
headermap" % (
----------------
You'll get an `IndexError` here if `strtable_size` is `0`.


https://reviews.llvm.org/D46485



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits